improvement: use null coalescing operator #359

connorhu · 2024-03-23T06:22:55Z

less code happier maintainer

The commit that has a rector prefix is the result of running the rector, the rest is manual.

connorhu · 2024-03-23T06:55:16Z

This kind of code has a simplified version:

        if (!isset(self::$instance)) {
            self::$instance = new sfAutoload();
        }

        return self::$instance;

        return self::$instance ?? self::$instance = new sfAutoload();

WDYT?

lib/action/sfAction.class.php

connorhu force-pushed the fix/null-coalescing-operator branch from 0896b16 to befc2bb Compare March 23, 2024 06:57

thePanz reviewed Apr 4, 2024

View reviewed changes

lib/action/sfAction.class.php Show resolved Hide resolved

connorhu changed the title ~~[action] improvement: use null coalescing operator~~ improvement: use null coalescing operator Apr 9, 2024

connorhu added 2 commits April 9, 2024 08:55

[action] improvement: use null coalescing operator

234d405

[rector] improvement: use null coalescing operator

2ddb388

connorhu force-pushed the fix/null-coalescing-operator branch 3 times, most recently from 4d3f444 to 765a53e Compare April 9, 2024 07:03

connorhu added 5 commits April 9, 2024 09:05

[plugin] improvement: use null coalescing operator

a505277

[request] improvement: use null coalescing operator

f145eae

[routing] improvement: use null coalescing operator

2e1e798

[storage] improvement: use null coalescing operator

dd13d3d

[validator] improvement: use null coalescing operator

800cd89

connorhu force-pushed the fix/null-coalescing-operator branch from 765a53e to 800cd89 Compare April 9, 2024 07:06

Provide feedback